Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.8] Fix UPDATE query bindings on PostgreSQL #29272

Merged
merged 2 commits into from
Jul 23, 2019
Merged

[5.8] Fix UPDATE query bindings on PostgreSQL #29272

merged 2 commits into from
Jul 23, 2019

Conversation

staudenmeir
Copy link
Contributor

The issue from #29165 also affects UPDATE queries. Only PostgreSQL doesn't yet remove select bindings.

We also don't need to put join bindings first, they always come before where bindings.

@taylorotwell taylorotwell merged commit 73da739 into laravel:5.8 Jul 23, 2019
@staudenmeir staudenmeir deleted the update-bindings branch July 23, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staudenmeir @taylorotwell