[5.8] Fixed cache repository getMultiple implementation

[GrahamCampbell]

The $default param of Psr\SimpleCache\CacheInterface::getMultiple is meant to be the default value, and not an array of defaults, or something of a similar form

---

For example, Symfony call getMultiple using new stdClass as the defaultm which crashes, because Laravel is trying to iterate over the parameter, instead of using it as the default.

Error Cannot use object of type stdClass as array 
    .../vendor/laravel/framework/src/Illuminate/Cache/Repository.php:131 Illuminate\Cache\Repository::getMultiple
    .../vendor/symfony/cache/Adapter/SimpleCacheAdapter.php:45 Symfony\Component\Cache\Adapter\SimpleCacheAdapter::doFetch
    .../vendor/symfony/cache/Adapter/AbstractAdapter.php:164 Symfony\Component\Cache\Adapter\AbstractAdapter::getItem
    .../vendor/php-http/cache-plugin/src/CachePlugin.php:143 Http\Client\Common\Plugin\CachePlugin::doHandleRequest

[driesvints]

You're correct. Good catch 👍

[GrahamCampbell]

Good catch by Bugsnag when I deployed to production like a fool, then had thousands of errors. 😆

[atymic]

Nice catch! I encountered this as well 😄
Thanks @GrahamCampbell

[crynobone]

Been testing the upcoming version with include this changes and Cache::getMultiple() is failing for following example:

Cache::driver('dynamodb')->getMultiple(['key1', 'key2', 'key3'], [
   'foo' => 'bar',
]);

It's as if the default can only be a string, which shouldn't be the case.

[driesvints]

@crynobone that's very odd. From what I can see in the current implementation on the 5.8 branch that cannot happen. The keys from the first array are used as keys in a new array and every value for each key is the default (which can be an array). Then those keys are filtered as values for the many method on the store. So to me the exception above can't possible be thrown.

Can you perhaps provide a failing test that proves the bug?

[crynobone]

Can you perhaps provide a failing test that proves the bug?

It's happening for DynamoDbStore, l'm try and have a look again and see if it persist. From the error it seem to chosen default $value instead of $key so it might be the array I'm using doesn't properly cast to string.

[LasseRafn]

This does not work for tagged caches. I'll submit a fix.

[GrahamCampbell]

Please send your fix to the 6.x branch. 5.8 is not accepting bug fixes anymore.

[LasseRafn]

👍