[5.8] Fixes Issue #28984, defer in app.js script prevents jquery components from loading. #29001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defer in javascript prevents jqueryui components from loading.
GrahamCampbell
changed the title
|
So we're now loading javascript in the head without defer? In order to handle the use of jquery-ui? This file is provided to get you started. It's yours to edit as you need it. It should handle the majority use-case and if you have an edge-case, change it. Jquery-ui is an edge case. But 🤷🏻♂️ |
|
Yeh, this is kinda odd. Ping @taylorotwell. |
|
Just move it back to the bottom I guess? Seems strange for it to cause issues with jquery-ui. Haven't used it in years though. |
|
Ping @taylorotwell cc: #28984 |
|
I've reverted this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defer in javascript prevents jqueryui components from loading.