[5.8] Fix bug in paginate method in Builder.php #28991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laravel has facility to pass columns (having clause columns define in select) in paginate method but it won't pass it to getCountForPagination() method which requires columns which can come from paginate method. Due to this, it is not able to add having clause in first count agreegator query hit to get total no of records.
|
@always18 please provide a practical code example on how this could be useful and how this would work. We recently removed this ability from the base query builder as well because it was conflicting with selecting specific columns. |
GrahamCampbell
changed the title
|
I think I've seen this before. I keeps getting added and removed after when it's added, it also is considered a bug by others... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel has facility to pass columns (having clause columns define in select) in paginate method but it won't pass it to getCountForPagination() method which requires columns which can come from paginate method. Due to this, it is not able to add having clause in first count agreegator query hit to get total no of records.