Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Error handling for maintenance mode commands #28765

Merged
merged 2 commits into from
Jun 8, 2019
Merged

[5.8] Error handling for maintenance mode commands #28765

merged 2 commits into from
Jun 8, 2019

Conversation

match
Copy link
Contributor

@match match commented Jun 8, 2019

Artisan command for controlling maintenance mode has not handled errors.

When execute commands by non-granted user,
artisan down throw Exception error messages, and also
artisan up shows Application is now live. but still maintenance mode.

This PR implements error handlings for that.

Command behavior is belows:

  • artisan down

    • success: Display Application is now in maintenance mode. with exit_status = 0
    • failed: Display Application is failed to enter maintenance mode. with exit_status = 1
  • artisan up

    • success to up: Display Application is now live. with exit_status = 0
    • already up: Display Application is already up. with exit_status = 0
    • failed: Display Application is failed to up. with exit_status = 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants