[5.8] Fix exception: The filename fallback must only contain ASCII characters. #28551
Conversation
driesvints
changed the title
|
@driesvints thanks, I improved the test! |
|
|
|
@taylorotwell thank you, I did not think about it. I fix it! |
| @@ -138,7 +138,8 @@ public function response($path, $name = null, array $headers = [], $disposition | |||
| { | |||
| $response = new StreamedResponse; | |||
|
|
|||
| $disposition = $response->headers->makeDisposition($disposition, $name ?? basename($path)); | |||
| $target_name = $name ?? basename($path); | |||
There was a problem hiding this comment.
@fragkp continuous-integration/styleci/pr says that everything is ok. camelCase is this private requirement?
There was a problem hiding this comment.
I'm wondering why stylci is not failing. camelCase is the default for variable names in laravel. You could check this in all other files.
There was a problem hiding this comment.
StyleCI cannot fail for those cases, because it is not possible to fix such cases without breaking dynamic code. There are also various special cases where snake case is needed.
There was a problem hiding this comment.
Okay, I fixed it.
But need to fix the automatic codestyle verification.
External developers don't know your local codestyle rules.
There was a problem hiding this comment.
But need to fix the automatic codestyle verification.
As I said, it is not broken. It is inherently not possible to safely rename variables.
Generate and pass
$filenameFallbackparam to\Symfony\Component\HttpFoundation\HeaderUtils::makeDisposition().Problem: downloading files with Cyrillic names does not work. Test complete.
\Illuminate\Tests\Filesystem\FilesystemAdapterTest::testDownloadNonAsciiFilename()