Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix session resolver in RoutingServiceProvider #28438

Merged
merged 3 commits into from
May 8, 2019

Conversation

golubkovden
Copy link
Contributor

Currently on validation exception FormRequest tries to resolve previous url from session. But if we don't use SessionServiceProvider then application fails with exception Class session does not exist.
The problem in sessionResolver that always tries to resolve session in application.

@driesvints
Copy link
Member

Can you explain your use case a bit more? In what situation do you need to disable the SessionServiceProvider?

@driesvints
Copy link
Member

Hmm, I think I see what you mean. In this case the session component is hard wired with the routing while there's a check performed in UrlGenerator to see if it's even set in the first place.

@golubkovden
Copy link
Contributor Author

Hmm, I think I see what you mean. In this case the session component is hard wired with the routing while there's a check performed in UrlGenerator to see if it's even set in the first place.

Yes, you're right

@taylorotwell taylorotwell merged commit 6eadc33 into laravel:5.8 May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants