Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.8] Allow logging out other devices without setting remember me cookie #28366

Merged
merged 1 commit into from
Apr 30, 2019
Merged

[5.8] Allow logging out other devices without setting remember me cookie #28366

merged 1 commit into from
Apr 30, 2019

Conversation

netpok
Copy link
Contributor

@netpok netpok commented Apr 29, 2019

Currently calling logoutOtherDevices sets a remember me cookie regardless that it existed originally or not, this pull request makes sure that it is only queued, when:

  • A recaller cookie already exists or
  • A recaller cookie is already queued

@netpok netpok force-pushed the fix-logout-other-devices-without-remember-me branch from 3f54bba to 807608b Compare April 29, 2019 15:55
@netpok netpok changed the title Allow logging out other devices without setting remember me cookie [5.8 ]Allow logging out other devices without setting remember me cookie Apr 29, 2019
@netpok netpok changed the title [5.8 ]Allow logging out other devices without setting remember me cookie [5.8] Allow logging out other devices without setting remember me cookie Apr 29, 2019
@taylorotwell taylorotwell merged commit 807608b into laravel:5.8 Apr 30, 2019
@netpok netpok deleted the fix-logout-other-devices-without-remember-me branch September 11, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netpok @taylorotwell