[5.8] Use coalesce operator #28287
Merged
[5.8] Use coalesce operator #28287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rentalhost
force-pushed
the
null-coalesce-operator
branch
from
1fb6dab to
f7bb1ca
Compare
driesvints
requested changes
Apr 22, 2019
driesvints
approved these changes
Apr 22, 2019
rentalhost
force-pushed
the
null-coalesce-operator
branch
from
f7bb1ca to
128ab45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #28280.
Applying null coalesce operator when possible in 7 files and 8 cases.
There is another case on file
src/Illuminate/View/Concerns/ManagesLayouts.php, but it was not too much accepted because it is hard to read. 😄Thanks to @kalessil Php Inspections (EA Ultimate) plugin.