[5.8] Fixed circular dependency - fix #28165

[kauanslr]

This PR fix the issue opened by me (#28165).

Basically, this code override the QueueManager::__call magic method when the Queue is mocked to prevend a circular dependency when calling a undefined method in the mock.

To prevent any break of existing feature i've made a simple test.

[taylorotwell]

Tests fail?

[kauanslr]

Tests fail?

Yes, i'm looking this.

Two memcached tests failed with PHP7.1, i'm trying to reproduce locally.

[kauanslr]

Done.

But the Travis is crazy.

[antoniopaisfernandes]

I've got a failing test when updating to 5.8.12

There was 1 error:

1) Tests\Feature\Claims\ArrivingAtTheWarehouseTest::dri_cores_are_split_by_UK_and_PL
BadMethodCallException: Call to undefined method Illuminate\Support\Testing\Fakes\QueueFake::assertPushedTimes()

[chrismeh]

assertPushedTimes is protected. Due to this fix, calls to assertPushedTimes will always hit __call and throw a BadMethodCallException. We could probably just go ahead and make assertPushedTimes public aswell?

[kauanslr]

We'll, looks like there many protected asserts. As @chrismeh mentioned, we cold just make these methods public.
I'll proceed with an PR with this resolution and create some tests to this problem too.

[kauanslr]

I've got a failing test when updating to 5.8.12

There was 1 error:

1) Tests\Feature\Claims\ArrivingAtTheWarehouseTest::dri_cores_are_split_by_UK_and_PL
BadMethodCallException: Call to undefined method Illuminate\Support\Testing\Fakes\QueueFake::assertPushedTimes()

Maybe, a alternative is to use assertPushed and pass times in callback parameter.

[antoniopaisfernandes]

@kauanslr I've, since, done that.

Queue::assertPushed(PrintAndEmail::class, 2);

I just viewed assertPushedTimes as a more verbose way of testing what I intended.

Thanks anyway.