[5.8] Email validation will reject non-string values #27735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekmd
reviewed
Mar 1, 2019
| @@ -626,7 +626,7 @@ protected function extractDistinctValues($attribute) | |||
| */ | |||
| public function validateEmail($attribute, $value) | |||
| { | |||
| return (new EmailValidator)->isValid($value, new RFCValidation); | |||
| return is_string($value) && (new EmailValidator)->isValid($value, new RFCValidation); | |||
There was a problem hiding this comment.
RFCValidation::isValid() also accepts an object implementing __toString():
There was a problem hiding this comment.
I changed this. Now, the validation method will first check to have a string or an object implementing __toString, before validating it using RFC.
|
Ok, thank you for the information. |
This commit will resolve the problem pointed by : #27735 (comment)
GrahamCampbell
changed the title
taylorotwell
pushed a commit
to illuminate/validation
that referenced
this pull request
Mar 4, 2019
This commit will resolve the problem pointed by : laravel/framework#27735 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Laravel 5.7, giving a non-string value to a validator was returning a validation error, but in Laravel 5.8, it throw an ErrorException with "Array to string conversion".
This pull-request fix this by checking that the value to validate is a string (using is_string method) or an object which has the __toString method, before validating it using Egulias EmailValidator.