Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Fix for route facade phpdoc to avoid Phan and PHPStorm errors #27379

Merged
merged 1 commit into from
Feb 1, 2019
Merged

[5.5] Fix for route facade phpdoc to avoid Phan and PHPStorm errors #27379

merged 1 commit into from
Feb 1, 2019

Conversation

websmurf
Copy link
Contributor

@websmurf websmurf commented Feb 1, 2019

We are currently in the process of integrating Phan (https://github.com/phan/phan) into our projects and both PHPstorm and Phan are complaining about the Route::middelware annotation:

src/Services/Api/Routes/Authentication.php:18 PhanParamTooFew Call with 1 arg(s) to \Illuminate\Support\Facades\Route::group() which requires 2 arg(s) defined at vendor/laravel/framework/src/Illuminate/Support/Facades/Route.php:25
src/Services/Api/Routes/Authentication.php:26 PhanParamTooFew Call with 1 arg(s) to \Illuminate\Support\Facades\Route::group() which requires 2 arg(s) defined at vendor/laravel/framework/src/Illuminate/Support/Facades/Route.php:25

I've narrowed it down to a fix that was applied on the 5.6 branch, this is a port of that fix to resolve this issue in the LTS version as well

@taylorotwell taylorotwell merged commit 593cc9d into laravel:5.5 Feb 1, 2019
@GrahamCampbell GrahamCampbell changed the title Fix for route facade phpdoc to avoid Phan and PHPStorm errors [5.5] Fix for route facade phpdoc to avoid Phan and PHPStorm errors Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants