[5.7] Add tests for decodeResponseJson #26741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test will prevent assertJsonStructure from breaking when an array with numeric keys which don't start from 0 is encoded to json and passed through it. See #26677 for more info.
This test will ensure that the exception message is thrown when invalid JSON is being returned from the route. See #26684
This was referenced Dec 4, 2018
nathanheffley
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some extra tests to make sure that the current testing behavior for most JSON assertions keeps on working like it does now. It makes sure that:
The two issues I linked to above were posted after some breaking changes were introduced because of cfab97f which essential broke the functionality which is now covered with these tests.