Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Use asset helper to generate full path urls in exception views #26411

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

mattdfloyd
Copy link
Contributor

No description provided.

wip
@sisve
Copy link
Contributor

sisve commented Nov 7, 2018

What happens if it was the url-generation for assets that caused the initial exception? Wouldn't that cause an eternal loop of view rendering and the exception handler, where the exception view itself causes another exception?

@mattdfloyd
Copy link
Contributor Author

@sisve No, it wouldn't.

@taylorotwell
Copy link
Member

Why?

@mattdfloyd
Copy link
Contributor Author

My need is to serve a Laravel application from a subdirectory via an Nginx proxy and without the asset helper, the files are served from the root url. I know the current stance is to not install a Laravel application into a subdirectory - I’m not. Instead I’m following this Servers For Hackers article: https://serversforhackers.com/c/nginx-php-in-subdirectory

@driesvints driesvints changed the title Use asset helper to generate full path urls in exception views [5.7] Use asset helper to generate full path urls in exception views Nov 8, 2018
@taylorotwell taylorotwell merged commit 63dd423 into laravel:5.7 Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants