Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.7] Add PHP 7.3 to Travis #26328

Merged
merged 3 commits into from
Oct 31, 2018
Merged

[5.7] Add PHP 7.3 to Travis #26328

merged 3 commits into from
Oct 31, 2018

Conversation

andreybolonin
Copy link
Contributor

No description provided.

@driesvints driesvints changed the title add php 7.3 to travis [5.7] add php 7.3 to travis Oct 31, 2018
@GrahamCampbell GrahamCampbell changed the title [5.7] add php 7.3 to travis [5.7] Add PHP 7.3 to Travis Oct 31, 2018
@mfn
Copy link
Contributor

mfn commented Oct 31, 2018

What happened to #26125 (the external dependencies)?

@GrahamCampbell
Copy link
Member

I think my tweak should fix the build.

@GrahamCampbell
Copy link
Member

Yeh, build fixed. Should be good to merge now. :)

@taylorotwell taylorotwell merged commit b18c253 into laravel:5.7 Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreybolonin @mfn @GrahamCampbell @taylorotwell