[5.7] Add an sqlite config option to enable foreign key constraints #26298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Sqlite, foreign key constraints need to be explicitly enabled for every database connection. So enabling them in the migrations (as suggested by the documentation) does not work. This PR enables the contraints for every connection to an sqlite database that has the config option `foreign_key_constraints` set to `true`. If the option is not set, nothing changes, so no breaking change is introduced. As foreign key constraints are the default behavior for all other databases I suggest switching this around for the next release and enable foreign keys unless this is set to `false`. If this is accepted I'll submit two more PRs for documentation and laravel/laravel.
This was referenced Oct 30, 2018
This was referenced Oct 30, 2018
GrahamCampbell
changed the title
gomasy
pushed a commit
to gomasy/bookshelf
that referenced
this pull request
Oct 31, 2018
This enables the sqlite `foreign_key_constraints` option that was introduced with laravel/framework#26298 for all new installs. The env variable DB_FOREIGN_KEYS was added to make it easier to handle this in testing (e.g. via phpunit.xml).
jenky
pushed a commit
to jenky/laravel
that referenced
this pull request
Nov 9, 2018
This enables the sqlite `foreign_key_constraints` option that was introduced with laravel/framework#26298 for all new installs. The env variable DB_FOREIGN_KEYS was added to make it easier to handle this in testing (e.g. via phpunit.xml).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Sqlite, foreign key constraints need to be explicitly enabled for every database connection. So enabling them in the migrations (as suggestednby the documentation) does not work.
This PR enables the contraints for every connection to an sqlite database that has the config option
foreign_key_constraintsset totrue.If the option is not set, nothing changes, so no breaking change is introduced.
As foreign key constraints are the default behavior for all other databases I suggest switching this around for the next release and enable foreign keys unless this is set to
false.If this is accepted I'll submit two more PRs for documentation and laravel/laravel.