Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Tidy up for artisan preset command #26244

Merged
merged 2 commits into from
Oct 25, 2018
Merged

[5.7] Tidy up for artisan preset command #26244

merged 2 commits into from
Oct 25, 2018

Conversation

michaelmano
Copy link
Contributor

@michaelmano michaelmano commented Oct 25, 2018

Sorry for 2 different commits for one pull request, I thought I was working on a different branch.

First commit

version bump for vue, package.json updated in on the Laravel repo - laravel/laravel#4831 however I had forgotten about the artisan preset command.

fix potential xss vulnerability in ssr (2.5.17)
fix v-for alias deconstruct regression (2.5.8)

Second commit

After running php artisan preset none and then trying to build your resources (after re running npm install or yarn) you get the following errors.

WARNING in ./resources/js/bootstrap.js
Module not found: Error: Can't resolve 'bootstrap' in 'resources/js'
 @ ./resources/js/bootstrap.js 14:2-22
 @ ./resources/js/app.js
 @ multi ./resources/js/app.js ./resources/sass/app.scss

WARNING in ./resources/js/bootstrap.js
Module not found: Error: Can't resolve 'jquery' in 'resources/js'
 @ ./resources/js/bootstrap.js 12:29-46
 @ ./resources/js/app.js
 @ multi ./resources/js/app.js ./resources/sass/app.scss

WARNING in ./resources/js/bootstrap.js
Module not found: Error: Can't resolve 'popper.js' in 'resources/js'
 @ ./resources/js/bootstrap.js 11:18-38
 @ ./resources/js/app.js
 @ multi ./resources/js/app.js ./resources/sass/app.scss

This is due to the file resources/js/bootstrap.js still running a try catch on requiring them.

I know its nothing big, I have removed the try catch.

@michaelmano michaelmano changed the title [5.7] Update vue version to 2.5.17 [5.7] Tidy up for artisan preset command Oct 25, 2018
@taylorotwell taylorotwell merged commit 005b44d into laravel:5.7 Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants