Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Remove Duplicated Code #26206

Merged
merged 1 commit into from
Oct 22, 2018
Merged

[5.7] Remove Duplicated Code #26206

merged 1 commit into from
Oct 22, 2018

Conversation

simoebenhida
Copy link
Contributor

this logic is duplicated on mergeWithLastGroup function

RouteGroup::merge($attributes, end($this->groupStack)); 

public function mergeWithLastGroup($new)
{
   return RouteGroup::merge($new, end($this->groupStack));
}

so it will need to be changed to

$this->mergeWithLastGroup(...func_get_args());

@taylorotwell taylorotwell merged commit 61d6a8a into laravel:5.7 Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants