[5.8] Test maintenance middleware #26075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@XuanQuynh , I think it can be pushed to 5.7 |
|
@TBlindaruk Thanks! Mr.Otwell will decide to close this pull request or push into another branch. We may wait for him. I will change the target if it's accepted. |
TBlindaruk
pushed a commit
to TBlindaruk/laravel-framework
that referenced
this pull request
Oct 11, 2018
Apply laravel#26075 to 5.7 (cherry picked from commit 05bff24)
taylorotwell
pushed a commit
that referenced
this pull request
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CheckForMaintenanceMode middleware contains a couple of use-case, so Let me add some tests to ensure some changes won't effect this class.