Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.7] Delete unneeded type check, since it will never be true #26053

Merged
merged 1 commit into from
Oct 10, 2018
Merged

[5.7] Delete unneeded type check, since it will never be true #26053

merged 1 commit into from
Oct 10, 2018

Conversation

TBlindaruk
Copy link
Contributor

Actually, we should not check the $data instanceof Collection, since Collection implements an Arrayable which checked before this.

@TBlindaruk
[5.7] Delete unneeded type check, since it will never be true
5bec6cf 
Actually, we should not check the `$data instanceof Collection`, since Collection implements an `Arrayable` which checked before this.
@taylorotwell taylorotwell merged commit 196c518 into laravel:5.7 Oct 10, 2018
@TBlindaruk TBlindaruk deleted the delete-unneeded-type-checking branch October 10, 2018 17:30
@staudenmeir staudenmeir mentioned this pull request Oct 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TBlindaruk @taylorotwell