New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.6] Revert email lang template changes. #25983

Merged

taylorotwell merged 2 commits into laravel:5.6 from TBlindaruk:revert

Oct 7, 2018

Contributor

TBlindaruk commented Oct 7, 2018 •

edited

Loading

Im not sure, but probably we also should reverting email lang template` (#25734) changes in 5.6 version

Since in prev 5.6 release we also had:

Fixed translation escaping (#25858, 4c46500)

The same revert was in 5.7 (#25963)


          [5.6] Revert email lang template changes.

af20dc6

I`m not sure, but probably we also should reverting `email lang template` ([laravel#25734](laravel#25734)) changes in 5.6 version

Since in prev 5.6 release we also had:
 - `Fixed translation escaping ([laravel#25858](laravel#25858), [4c46500](https://github.com/laravel/framework/commit/4c465007bbf51d7f269871cd76b6d99de7df90bb))` for fixed translation escaping

The same revert was in 5.7 (laravel#25963)

Contributor Author

TBlindaruk commented Oct 7, 2018

@laurencei , Should we revert this on 5.6 too?

TBlindaruk requested a review from laurencei

October 7, 2018 06:47


          [5.6] Revert email lang template changes.

6b808f9

 - add `comma` after last value in array.

taylorotwell merged commit 71964f8 into laravel:5.6

TBlindaruk deleted the revert branch

October 7, 2018 20:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet