[5.8] Register binding for schema facade #25512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzliedke
added a commit
to franzliedke/framework
that referenced
this pull request
Sep 7, 2018
Because of laravel#25497 and laravel#25512, all facades in core are now properly using service identifiers (strings) for resolving their "root" service from the container. This means that the hack for resolving objects directly can now be removed. In case you're wondering why this is necessary: As far as I can tell, facade features like ::swap() did not work with these types of facades (Blade and Schema), because those methods did not deal with the possibility of objects being returned.
taylorotwell
pushed a commit
that referenced
this pull request
Sep 10, 2018
Because of #25497 and #25512, all facades in core are now properly using service identifiers (strings) for resolving their "root" service from the container. This means that the hack for resolving objects directly can now be removed. In case you're wondering why this is necessary: As far as I can tell, facade features like ::swap() did not work with these types of facades (Blade and Schema), because those methods did not deal with the possibility of objects being returned.
|
@franzliedke I resent this in to master while keeping in mind the previous breakages. I'd appreciate your review: #38017 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #25391 and #25497, this registers a binding in the container that the
Schemafacade can use.This means all facades in Laravel's core use strings to describe the facade root, which could let us remove some complexity from the base facade class in a next step. 😃
Open question:
\Illuminate\Database\Schema\Builderin this case.