[5.6] Bugfix: concurrent write of bootstrap/cache/packages.php #25012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is no bootstrap/cache/*.php, the php process will attemp to build bootstrap/cache/packages.php, bootstrap/cache/services.php and etc. If there are two or more php process doing the same thing, it is possible for one of the process to read a *dirty* bootstrap/cache/packages.php (not yet finish writing by another process). The solution add write and read lock to prevent read an *dirty* packages.php and write a wrong services.php file.
bbiao
changed the title
|
@taylorotwell would you backport this to branch 5.5 ? |
TheNodi
added a commit
to TheNodi/framework
that referenced
this pull request
May 2, 2020
Filesystem get was introduced in laravel#25012 as a locking mechanism to prevent partial reads of the manifest file. In laravel#26010 the locking was substituted by an atomic rename-based file write. The get called survived the refactor, resulting a noop file_get_contents that just trashes the output. This commit removes the read entirely. - return $this->manifest = file_exists($this->manifestPath) ? $this->files->getRequire($this->manifestPath) : []; }
TheNodi
added a commit
to TheNodi/framework
that referenced
this pull request
May 2, 2020
Filesystem get was introduced in laravel#25012 as a locking mechanism to prevent partial reads of the manifest file. In laravel#26010 the locking was substituted by an atomic rename-based file write. The get called survived the refactor, resulting a noop file_get_contents that just trashes the output. This commit removes the read entirely.
taylorotwell
pushed a commit
that referenced
this pull request
May 2, 2020
Filesystem get was introduced in #25012 as a locking mechanism to prevent partial reads of the manifest file. In #26010 the locking was substituted by an atomic rename-based file write. The get called survived the refactor, resulting a noop file_get_contents that just trashes the output. This commit removes the read entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no bootstrap/cache/*.php, the php process will attemp to
build bootstrap/cache/packages.php, bootstrap/cache/services.php and
etc. If there are two or more php process doing the same thing, it is
possible for one of the process to read a dirty
bootstrap/cache/packages.php (not yet finish writing by another
process).
The solution add write and read lock to prevent read an dirty
packages.php and write a wrong services.php file.