[5.7] Allow setting full Mailgun API URL #24994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adjusted to be a non-breaking change. |
This was referenced Jul 29, 2018
|
Could this be added to 5.5 LTS and up as well? (the non breaking change version) |
|
5.5 is closed to anything other than bug fixes, and this looks like a new feature, sorry. |
taylorotwell
pushed a commit
that referenced
this pull request
Nov 22, 2018
taylorotwell
pushed a commit
to illuminate/mail
that referenced
this pull request
Nov 22, 2018
This was fixed for 5.7 but backporting this to 5.5 wouldn't leave all the LTS folks in the dark who still want to use the EU region. Issue: laravel/framework#26576 Original fix: laravel/framework#24994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #24987.
Mailgun recently launched a new EU endpoint which isn't compatible with the current Laravel integration as the URL is forced to begin with
https://api.mailgun.net/v3/, but now needs to being withhttps://api.eu.mailgun.net/v3/.This PR would allow setting the full URL for Mailgun's API manually, which ensures any future endpoints they may launch can also be supported.