Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.5] Check for timestamps when creating pivot model from raw attributes #23963

Merged
merged 1 commit into from
Apr 25, 2018
Merged

[5.5] Check for timestamps when creating pivot model from raw attributes #23963

merged 1 commit into from
Apr 25, 2018

Conversation

luchaos
Copy link
Contributor

@luchaos luchaos commented Apr 21, 2018

By doing the timestamps check again after actually having the attributes filled.
Fixes #23601
(Now on the proper version branch @GrahamCampbell )

@luchaos luchaos mentioned this pull request Apr 21, 2018
Closed
luchaos referenced this pull request Apr 22, 2018
@staudenmeir
Remove attribute filling from pivot model
a738129
@GrahamCampbell
Copy link
Member

Thanks for following this up. I'm sure Taylor will review this next week. :)

@taylorotwell taylorotwell merged commit fca815e into laravel:5.5 Apr 25, 2018
@luchaos luchaos deleted the 5.5 branch April 25, 2018 22:09
@luchaos luchaos restored the 5.5 branch April 25, 2018 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luchaos @GrahamCampbell @taylorotwell