-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.6] Disable model relationship touching #23469
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8483ce8
Allow disabling touching models and their children temporarily
tonysm efa95a6
Fix touching the model directly not respecting the without touch
tonysm 435320d
Make sure we can update a model without touching its timestamps
tonysm 5708067
Test deletion of children also respects the parent no touching
tonysm 84cc466
Fix style issue
tonysm ddb1192
More tests for the direct model touching and the chain
tonysm 5cda08e
Test nested relationships are touched when direct parent is ignored
tonysm 940aeab
Touch models own timestamps when in withoutTimestamps scope
tonysm a3889bc
Remove unused conditional
tonysm 7371846
Use static instead of self
tonysm 881921a
Remove ignoring direct touch calls in withoutTouching scope
tonysm 620eee1
Add withoutTouchingOn that receives all models classes to ignore at once
tonysm 53510ea
Add unit testing for the withoutTouchingOn method
tonysm 4a7a25f
Allow checking if class is in the ignore touching scope
tonysm 3629625
Remove shouldTouch and replace its usage with the isIgnoredOnTouch me…
tonysm e46179a
Align use statements
tonysm 8d1ade1
Remove extra line
tonysm 1d85125
Rename method
tonysm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
call_user_func($callback)
better than$callback()
?