[5.4][PHP-7.2] Make addNestedWhereQuery PHP 7.2 compatible #20635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PHP 7.2, `count()` can only be called on arrays and `Countable`
The old code did do this in `addNestedWhereQuery`:
```PHP
if (count($query->wheres)) {
```
Which could translate to `if (count(NULL)) {` which will produce:
` ErrorException: count(): Parameter must be an array or an object that implements Countable`
Because the phpdoc says it's supposed to be an array and I saw another place having an explicit `(array)`-cast, my approach was to simply ensure it's an array by default and don't have special cases for `NULL` case anymore
vrza
added a commit
to vrza/framework
that referenced
this pull request
Mar 26, 2021
In PHP 7.2, `count()` can only be called on arrays and `Countable`
The old code did do this in `addNestedWhereQuery`:
if (count($query->wheres)) {
Which could translate to `if (count(NULL)) {` which will produce:
`ErrorException: count(): Parameter must be an array or an object
that implements Countable`
See 5.4 pull request laravel#20635
arjanwestdorp
added a commit
to arjanwestdorp/framework
that referenced
this pull request
Jul 20, 2021
arjanwestdorp
added a commit
to arjanwestdorp/framework
that referenced
this pull request
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP 7.2,
count()can only be called on arrays andCountableThe old code did do this in
addNestedWhereQuery:Which could translate to
if (count(NULL)) {which will produce:ErrorException: count(): Parameter must be an array or an object that implements CountableBecause the phpdoc says it's supposed to be an array and I saw another place having an explicit
(array)-cast, my approach was to simply ensure it's an array by default and don't have special cases forNULLcase anymore