Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Tweak tests for PHP7.2 #20378

Merged
merged 1 commit into from
Aug 1, 2017
Merged

[5.4] Tweak tests for PHP7.2 #20378

merged 1 commit into from
Aug 1, 2017

Conversation

laurencei
Copy link
Contributor

Some of the tests were changed in PR #20258 to be ready for PHP7.2.

I dont think the new tests correctly encapsulate what we are testing for.

Since we know the results returned are expected to be null - then lets just test for that. This way we can capture any changes in the future, which could potentially now be hidden with the dynamic typecasting of results in the test.

@taylorotwell taylorotwell merged commit e2ce0b5 into laravel:5.4 Aug 1, 2017
@laurencei laurencei deleted the tweaktests branch August 1, 2017 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants