-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.4] fix doctrine/inflector version to pull 1.1.0 #20227
[5.4] fix doctrine/inflector version to pull 1.1.0 #20227
Conversation
I think this should also go into master sense Laravel is PHP >= 7.0. And version 1.2 is > php version 7.1. |
@morloderex we can handle it after marge just to avoid conflicts for now |
Surely this should be |
@ntzm thanks .. @taylorotwell updated |
Actually 1.2.0 stills requires (only) PHP 7.0 |
@taylorotwell @themsaid don't know if its the best approach to fix #20214 As was tested here composer correctly handle doctrine/inflector version with the With this PR we are locked on I suggest to revert this PR and treat the #!/usr/bin/env bash
wget https://github.com/laravel/laravel/archive/master.zip
unzip master.zip -d working
cd working/laravel-master
composer install
rm composer.lock
zip -ry ../../laravel-craft.zip .
cd ../..
mv laravel-craft.zip public/laravel-craft.zip
rm -rf working
rm master.zip |
any updates on this ? |
What about 5.3 ? Problem 1 |
does this mean 5.4 won't work with php 5.6.* anymore? |
It's not the same package, doctrine/inflector requirement is fine. the problem is with laravel/installer and the zip that was built on php 7. |
@MarcTroesken I added |
Having the same issue installing laravel 5.4 with Php5.6. |
@nickwuk Have you updated to the latest version of laravel 5.4? |
@ntzm the composer.json file require section includes |
@nickwuk The latest version is 5.4.32, I recommend you update 😄 |
@ntzm that's what I'm trying to do, I'm trying to update Laravel together with other packages using composer. What I find is that if I remove the require reference to `Problem 1 Problem 2 Problem 3 Problem 4 Problem 5 Problem 6 Problem 7 |
@simonpeters @MarcTroesken, this bit me today and I would suggest using the platform config option in
I would also suggest that this should be added to the project's |
I had an issue like this, and my troubles was linked to my composer.lock had been generated by my local php installation which was 7.1. When I managed to get php 7.0 and generate a new composer.lock, I got doctrine/inflector version 1.0.* |
Since 1.2.0 requires minimum version php7.1 now: https://github.com/doctrine/inflector/releases/tag/v1.2.0