Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] fix doctrine/inflector version to pull 1.1.0 #20227

Merged
merged 2 commits into from
Jul 24, 2017
Merged

[5.4] fix doctrine/inflector version to pull 1.1.0 #20227

merged 2 commits into from
Jul 24, 2017

Conversation

themsaid
Copy link
Member

Since 1.2.0 requires minimum version php7.1 now: https://github.com/doctrine/inflector/releases/tag/v1.2.0

@morloderex
Copy link
Contributor

morloderex commented Jul 24, 2017

I think this should also go into master sense Laravel is PHP >= 7.0. And version 1.2 is > php version 7.1.

@themsaid
Copy link
Member Author

themsaid commented Jul 24, 2017

@morloderex we can handle it after marge just to avoid conflicts for now

@ntzm
Copy link
Contributor

ntzm commented Jul 24, 2017

Surely this should be ~1.1.0 in case of bug or security fixes on 1.1.x?

@taylorotwell
Copy link
Member

@ntzm is correct @themsaid

@themsaid
Copy link
Member Author

@ntzm thanks .. @taylorotwell updated

@X-Coder264
Copy link
Contributor

Actually 1.2.0 stills requires (only) PHP 7.0
The bump to PHP 7.1 was postponed until 1.3.0
doctrine/inflector#50 (comment)
That means that 1.2 can be used on L5.5 and this PR doesn't need to get merged into the master.

@gmsantos
Copy link
Contributor

@taylorotwell @themsaid don't know if its the best approach to fix #20214

As was tested here composer correctly handle doctrine/inflector version with the ~1.0 constraint.

With this PR we are locked on 1.1.*, even if we are running PHP 7.1 and we can't have the benefit of newer minor version of doctrine/inflector

I suggest to revert this PR and treat the laravel/installer issue with another approach, like removing composer.lock from http://cabinet.laravel.com/latest.zip in https://github.com/laravel/installer/blob/master/zipper.sh

#!/usr/bin/env bash
wget https://github.com/laravel/laravel/archive/master.zip
unzip master.zip -d working
cd working/laravel-master
composer install

rm composer.lock

zip -ry ../../laravel-craft.zip .
cd ../..
mv laravel-craft.zip public/laravel-craft.zip
rm -rf working
rm master.zip

@jpkontreras
Copy link

any updates on this ?

@MarcTroesken
Copy link

MarcTroesken commented Jul 26, 2017

What about 5.3 ?
Still can't deploy on envoyer:

Problem 1
- Installation request for doctrine/instantiator 1.1.0 -> satisfiable by doctrine/instantiator[1.1.0].
- doctrine/instantiator 1.1.0 requires php ^7.1 -> your PHP version (7.0.12) does not satisfy that requirement.
Problem 2
- doctrine/instantiator 1.1.0 requires php ^7.1 -> your PHP version (7.0.12) does not satisfy that requirement.
- phpunit/phpunit-mock-objects 4.0.2 requires doctrine/instantiator ^1.0.2 -> satisfiable by doctrine/instantiator[1.1.0].
- Installation request for phpunit/phpunit-mock-objects 4.0.2 -> satisfiable by phpunit/phpunit-mock-objects[4.0.2].

@simonpeters
Copy link

does this mean 5.4 won't work with php 5.6.* anymore?

@lk77
Copy link

lk77 commented Jul 26, 2017

It's not the same package, doctrine/inflector requirement is fine.
5.4 is working with 5.6.

the problem is with laravel/installer and the zip that was built on php 7.
i think we need to generate multiple zip for php5.6 / php7.0 / php7.1

@simonpeters
Copy link

@MarcTroesken I added --ignore-platform-reqs to my composer install options, worked just fine

@Ezyweb-uk
Copy link

Having the same issue installing laravel 5.4 with Php5.6.

@ntzm
Copy link
Contributor

ntzm commented Aug 7, 2017

@nickwuk Have you updated to the latest version of laravel 5.4?

@Ezyweb-uk
Copy link

Ezyweb-uk commented Aug 7, 2017

@ntzm the composer.json file require section includes "laravel/framework": "5.4.*" and Laravel version 5.4.17 is already installed.

@ntzm
Copy link
Contributor

ntzm commented Aug 8, 2017

@nickwuk The latest version is 5.4.32, I recommend you update 😄

@Ezyweb-uk
Copy link

@ntzm that's what I'm trying to do, I'm trying to update Laravel together with other packages using composer. What I find is that if I remove the require reference to "laravel/framework": "5.4.*" in composer.json then all the other packages update ok. Also if I only include "laravel/framework": "5.4.*" in composer.json then Laravel updates ok, but not if all packages are required together; When Laravel is required with the other packages then multiple 'no matching package found' errors show.

`Problem 1
- The requested package omnipay/common could not be found in any versio
n, there may be a typo in the package name.

Problem 2
- Installation request for laravel/framework 5.4.* -> satisfiable by la
ravel/framework[5.4.x-dev].
- laravel/framework 5.4.x-dev requires doctrine/inflector ~1.1.0 -> no
matching package found.

Problem 3
- Installation request for omnipay/omnipay 2.* -> satisfiable by omnipa
y/omnipay[2.3.x-dev].
- omnipay/omnipay 2.3.x-dev requires omnipay/common ~2.3 -> no matching
package found.

Problem 4
- Installation request for omnipay/stripe ~2.0 -> satisfiable by omnipa
y/stripe[V2.4.7].
- omnipay/stripe V2.4.7 requires omnipay/common ~2.0 -> no matching pac
kage found.

Problem 5
- Installation request for omnipay/paypal ~2.0 -> satisfiable by omnipa
y/paypal[v2.6.3].
- omnipay/paypal v2.6.3 requires omnipay/common ~2.0 -> no matching pac
kage found.

Problem 6
- Installation request for omnipay/mollie 3.* -> satisfiable by omnipay
/mollie[3.2.x-dev].
- omnipay/mollie 3.2.x-dev requires omnipay/common ~2.2 -> no matching
package found.

Problem 7
- laravel/framework 5.4.x-dev requires doctrine/inflector ~1.1.0 -> no
matching package found.`

@w0rd-driven
Copy link

@simonpeters @MarcTroesken, this bit me today and I would suggest using the platform config option in composer.json instead:

"config": {
    "platform": {
        "php": "5.6.4"
    }
}

I would also suggest that this should be added to the project's composer.json Laravel puts in place moving forward because the attitude from http://doctrine-project.org/2017/07/25/php-7.1-requirement-and-composer.html suggests this will happen again. Trying to disarm footguns of this magnitude seems like a sane approach, though I may be suggesting an answer to a problem only people like myself are having and this fix may not address the community as a whole.

@hultberg
Copy link

I had an issue like this, and my troubles was linked to my composer.lock had been generated by my local php installation which was 7.1. When I managed to get php 7.0 and generate a new composer.lock, I got doctrine/inflector version 1.0.*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.