Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve aliases from container when using parameters #19071

Merged
merged 4 commits into from
May 5, 2017

Conversation

lighe
Copy link
Contributor

@lighe lighe commented May 5, 2017

$app->bind(CustomClass::class, function($app, $params) { ... });
$app->alias(CustomClass::class, 'CustomAlias');
$app->makeWith('CustomAlias', [..]); // exception "Class CustomAlias does not exist"

When passing parameters to Illuminate/Container/Container resolve() method, the alias will not be resolved correctly. This pull request fixes that.

@taylorotwell
Copy link
Member

Can you add a test?

@lighe
Copy link
Contributor Author

lighe commented May 5, 2017

Sure, I will sort over the weekend and update the pull request.

@taylorotwell taylorotwell merged commit d4b4e18 into laravel:5.4 May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants