[5.4] Set connection on model factory #18846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #18769 we set the Model connection while retrieving it, we did that to fix the failing test @adamwathan shows in https://github.com/laravel/framework/pull/18760/files#diff-2b6eae4ede78d520041c54df36afb408R1064
However when you create a model via
factory()the connection is not set on the created model, so using->is()to compare the model you just created and a model retrieved from the DB will fail since the one created byfactory()has$connection = null.This PR sets the connection while creating the model using
factory().