Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Allow Validator extension to use array-style callable #18399

Merged
merged 2 commits into from
Mar 19, 2017
Merged

[5.4] Allow Validator extension to use array-style callable #18399

merged 2 commits into from
Mar 19, 2017

Conversation

adamthehutt
Copy link
Contributor

Currently, a validator extension can be either a Closure or a string denoting a class and method. For complex validation scenarios, however, it's useful to be able to pass an object and method in the array-style callable format (i.e. [$object, $method] instead of "$class@$method").

Currently, a validator extension can be either a Closure or a string denoting a class and method. For complex validation scenarios, however, it's useful to be able to pass an object and method in the array-style callable format (i.e. [$object, $method] instead of "$class@$method").
@@ -1026,7 +1026,7 @@ protected function callExtension($rule, $parameters)
{
$callback = $this->extensions[$rule];

if ($callback instanceof Closure) {
if ($callback instanceof Closure || is_array($callback)) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you can change this line into something like this: if (is_callable($callback)) {. And it will achieve the same result.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'll update the pull request.

@adamthehutt adamthehutt changed the title Allow Validator extension to use array-style callable [5.4] Allow Validator extension to use array-style callable Mar 18, 2017
@taylorotwell taylorotwell merged commit ab37f22 into laravel:5.4 Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants