Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Added check not to retry non-existing jobs for clarity #18279

Merged
merged 1 commit into from
Mar 9, 2017

Conversation

lasselehtinen
Copy link
Contributor

@lasselehtinen lasselehtinen commented Mar 9, 2017

Currently if you try to requeue non-existing jobs with artisan queue:retry it shows the error message and the info that the job has been requeued.

[root@server www]$ php artisan queue:retry foobar
No failed job matches the given ID [foobar].
The failed job [foobar] has been pushed back onto the queue!

This pull request changes the logic so the job is not retried if the id does not even exist and only shows the proper error message.

vagrant@homestead:~/Code/foobar$ php artisan queue:retry foo bar 9561
No failed job matches the given ID [foo].
No failed job matches the given ID [bar].
The failed job [9561] has been pushed back onto the queue!

@taylorotwell taylorotwell merged commit 1010175 into laravel:5.4 Mar 9, 2017
@GrahamCampbell GrahamCampbell changed the title Added check not to retry non-existing jobs for clarity [5.4] Added check not to retry non-existing jobs for clarity Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants