[5.4] allow scheduling of queued jobs #18235
Conversation
| * @param \Illuminate\Contracts\Queue\ShouldQueue $job | ||
| * @return \Illuminate\Console\Scheduling\Event | ||
| */ | ||
| public function job(ShouldQueue $job) |
There was a problem hiding this comment.
Why not add a $name = null as the second parameter?
There was a problem hiding this comment.
Name is used solely for the cache mutex name. I don't see a case where you'd want to set that as anything other than the full class name of the Job.
There was a problem hiding this comment.
@tomschlick my bad, I mixed it up with the scheduled command name
|
Features that don't have compatibility usually go on the current branch in this repo. Master is for 5.5. |
|
Merged with a few tweaks... I removed the ShouldQueue type-hint in case people are using jobs in a synchronous "command-bus" fashion, also allowed passing a string class name which will resolve the job from the container. Thanks! |
|
sounds good, thanks! |
|
Wow... no more commands that queues jobs 🎉👍🏻 |
|
@taylorotwell This should be added to the docs. Had to find this PR to find out if it this functionality existed. Doesn't appear to be in 5.4/5.5 docs. |
As proposed in laravel/ideas#457, this simple addition allows us to schedule a job to be queued at a specific interval.
This enables you do have something like this
In this example, you might be scheduling a heartbeat to be run from the queue workers themselves. This is something I currently do in production which ping's Envoyer's heartbeat endpoints to tell me if a queue is backed up for too long.
Right now, if you want to do this you have to either create a dedicated command per job you want to schedule, or use the
$schedule->call();method passing in a closure which can be overly verbose for the Kernel file. This provides a clean abstraction to that.