Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Add test for validation of ratio with no fractional part #17980

Merged
merged 2 commits into from
Feb 17, 2017
Merged

[5.4] Add test for validation of ratio with no fractional part #17980

merged 2 commits into from
Feb 17, 2017

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented Feb 17, 2017

Test for #17943, which is the main fix.
See also the subsequent #17963, which brings more robustness.

Then these changes will have to be backported to 5.3 (different file structure).

@taylorotwell taylorotwell merged commit eb1ea6e into laravel:5.4 Feb 17, 2017
@vlakoff vlakoff deleted the image_validation branch February 18, 2017 00:11
@vlakoff vlakoff mentioned this pull request Feb 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlakoff @taylorotwell