Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] @lang directive is not working with json lang file #17919

Merged
merged 1 commit into from
Feb 15, 2017

Conversation

yusufyilmaz
Copy link
Contributor

@lang Blade directive is not working. This PR tries to adjust @lang directive with new "getFromJson" method. If json is not set then "get" method will be called as fallback.

@lang Blade directive is not working. This PR tries to adjust @lang directive with new "getFromJson" method. If json is not set then "get" method will be called as fallback.
@GrahamCampbell GrahamCampbell changed the title @lang directive is not working with json lang file [5.4] @lang directive is not working with json lang file Feb 14, 2017
@taylorotwell
Copy link
Member

Use the trans directive.

@yusufyilmaz
Copy link
Contributor Author

Hey @taylorotwell there is no trans directive in Laravel5.4 I do not see that directive in documentation or in any part of the code. I have only seen this directive at laravel-news post which was written by @themsaid . I also confirm that trans directive not working (because there is not trans directive I think) on my Laravel5.4.11 installation.

@taylorotwell taylorotwell reopened this Feb 15, 2017
@taylorotwell taylorotwell merged commit ab814e9 into laravel:5.4 Feb 15, 2017
@taylorotwell
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants