Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Don’t require PhpRedis extension for tests #17910

Merged
merged 2 commits into from
Feb 13, 2017

Conversation

tillkruss
Copy link
Contributor

@tillkruss tillkruss commented Feb 13, 2017

Followup on #17882.

@taylorotwell taylorotwell merged commit 1c868e1 into laravel:5.4 Feb 13, 2017
];

if (extension_loaded('redis')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad idea really, because these tests won't show up as skipped, they'll just get hidden all together

@taylorotwell
Copy link
Member

Wait so now the Predis tests won't run on my machine if I don't have PHPRedis installed?

@tillkruss
Copy link
Contributor Author

No, same like before. Predis will run as long as host/port are configured. If not they are not set, PHPUnit will skip the tests.

PhpRedis will only be tested if the extension is installed. If not, only Predis is tested.

@tillkruss tillkruss deleted the skip-phpredis branch April 16, 2017 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants