-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.4] Support numeric arguments in break and continue #17603
Merged
taylorotwell
merged 9 commits into
laravel:5.4
from
michaeltintiuc:michaeltintiuc-patch-1
Jan 31, 2017
Merged
[5.4] Support numeric arguments in break and continue #17603
taylorotwell
merged 9 commits into
laravel:5.4
from
michaeltintiuc:michaeltintiuc-patch-1
Jan 31, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the [PHP documentation](http://php.net/manual/en/control-structures.break.php) >break accepts an optional numeric argument which tells it how many nested enclosing structures are to be broken out of. The default value is 1, only the immediate enclosing structure is broken out of.
Minimum count of structures to break out of is 1
Allow for values greater than 9
Implementing a similar feature in versions 5.2+ is trivial, would be my pleasure to do so. |
GrahamCampbell
changed the title
Support numeric arguments in break and continue
[5.4] Support numeric arguments in break and continue
Jan 27, 2017
Just to make it a bit more clear: @foreach ($users as $user)
@foreach($user->posts as $post)
@if ($post->id == 1)
@php
break 2;
@endphp
@endif
@endforeach
@endforeach Now becomes: @foreach ($users as $user)
@foreach($user->posts as $post)
@if ($post->id == 1)
@break(2)
@endif
@endforeach
@endforeach I could also write some tests if there is a need for such. |
Can you provide tests? |
@taylorotwell Will do. Would you like a test for each case? For example:
|
Testing for a proper argument passed as well as white-spaced and a faulty (less than 1) ones
Arguments that are less than zero are now caught by the regexp
Testing for a proper argument passed as well as white-spaced and a faulty (less than 1) ones
@taylorotwell Please, have a look and let me know if there's anything I might've missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the PHP documentation
Usage
To break out of 2 nested loops:
@break(2)
compiles tobreak 2;
Compatibility
($user->id == 2)
are supported@continue( 2 )
compiles tocontinue 2;