Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Use the relation query instance to perform updateOrCreate #17105

Merged
merged 1 commit into from
Jan 4, 2017
Merged

[5.3] Use the relation query instance to perform updateOrCreate #17105

merged 1 commit into from
Jan 4, 2017

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Jan 3, 2017

Currently running updateOrCreate on a HasManyThrough relation calls the updateOrCreate method of Eloquent\Builder, this causes the attributes of the instance returned to be filled with all the fields since the Builder does select *, unlike the relation builder which does select model_table.*.

So this PR includes the two methods required for an udpateOrCreate operation to run successfully.

@themsaid themsaid mentioned this pull request Jan 3, 2017
Closed
@taylorotwell taylorotwell merged commit 865bdd3 into laravel:5.3 Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@themsaid @taylorotwell