[5.3] Update read/unread notification relationships to use base relationship #17093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "read" and "unread" relationships for notifications use the same logic as the base relationship definition, except for the addition of the where clause. This PR updates the "read" and "unread" relationships to build off of the base
notifications()relationship, instead of redefining the same logic.The main reason for the PR is to make it easier for those that wish to use their own custom
Modelfor thenotificationstable, instead of the built inDatabaseNotificationmodel. If one wants to use their own model, one would need to override all three relationships. With this change, one only needs to override the basenotifications()relationship, and the read/unread relationships can be left alone.