[5.3] Illuminate\Validation\Rules\Unique bug fix #16948
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new validation rules since Laravel 5.3 the following validation fails:
When it's parsed in the underneath method in
Illuminate\Validation\Validator
, comma separated arguments will be seen as a separate column, because of thestr_getcsv
. This causes an error on line 1520.I solved it with the following PR. Perhaps not the most beautiful approach, so let me know what you think.