[5.3] Fix column overlaping on withCount #16895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16645
Current wrong result for this function:
New result:
Notice the ID changed and it removed the inner join columns from the query, they are inside the pivot only now...
4
is the id of therole_user
table, it was replacing the id of the role generating a wrong result for this query...Repo for testing purposes:
https://github.com/cabalopolis/with-count-bug.
Not sure maybe we should target 5.4...