[5.4] Enforce an orderBy clause for chunk() and chunkById() #16283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generally seems OK to me. Latest 5.3 has been merged to master. |
|
Rebased. 🙋♀️ |
|
I have a doubt: In the query builder,
ping :) @GrahamCampbell |
|
Just submitted #16513 to bring a fix to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a first insight. Before this is merged, latest 5.3 changes should have been merged into master, then this PR will have to be updated.
Follow-up to #11623.
orderBy clause is already enforced for
each, it just makes sense to enforce it inchunkandchunkByIdas well. User code may work with this clause omitted, but that's damn dangerous and prone to future errors.By the way, an interesting article on the subject: Paging Through Results.