[5.3] Reset artisan application after running migrations in tests #15531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| namespace Illuminate\Foundation\Testing; | |||
|
|
|||
| use Illuminate\Foundation\Console\Kernel; | |||
There was a problem hiding this comment.
We might want to use Illuminate\Contracts\Console\Kernel here... I think that is what is bound to the container when the app is bootstrapped.
There was a problem hiding this comment.
Yes correct, IDE's fault. Fixing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use the DatabaseMigrations trait in tests, a call to $this->artisan('migrate') is made for every test, this call creates an instance of Illuminate\Console\Application and resolves all commands.
Inside any test if you try to swap any console command dependency using $this->app->bind() and then call the command via $this->artisan('command') the old concrete implementation will be called instead of the swapped dummy one.
This PR fixes that by resetting the artisan application instance so that it gets rebuilt inside the actual tests allowing the swapping of bindings.