-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Added Container::getFactory()
method
#15415
Conversation
Container::getFactory()
methodContainer::getFactory()
method
|
||
/** | ||
* Get a closure to resolve the given type from the container. | ||
* The given closure will have an optional [array $parameters] parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply my earlier comments.
We can add it later. There's plenty of implementation code without the proper contract in the rest of the framework. I even made a PR about that a gazillion years ago. I'll amend with the CS fixes. |
Yeh, I know. That's really unfortunate. I'm just trying to avoid making things worse. :) |
99b5d92
to
22aad12
Compare
@GrahamCampbell if this is merged, I can PR the BC change in the Container contract to master 😄 |
Thanks for making those changes. I'd personally rather it only went to master, but I can see arguments for it going to 5.3 in this way too. Ultimately, Taylor will decide if he wants to merge this PR. :) |
Awesome! |
Without the BC change that #15414 proposed.