Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Swap Drop for DropIfExists in all stubs #15230

Merged
merged 1 commit into from
Sep 2, 2016
Merged

[5.3] Swap Drop for DropIfExists in all stubs #15230

merged 1 commit into from
Sep 2, 2016

Conversation

mbardelmeijer
Copy link
Contributor

PR #15113 swapped Schema::drop call with Schema::dropIfExists for the create stub. This creates a inconsistency between the php artisan make:* commands.

This PR changes all drop calls with dropIfExists to be consistent.

First Laravel PR, woohoo!

@taylorotwell taylorotwell merged commit ccf1724 into laravel:5.3 Sep 2, 2016
@GrahamCampbell
Copy link
Member

Why would we want this? The other change was only there for dev reasons.

@canvural canvural mentioned this pull request Jan 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbardelmeijer @GrahamCampbell @taylorotwell