[5.3] Controller closure middleware

[JosephSilber]

This will allow registering a closure middleware in the controller's constructor, so that any auth/session stuff can be called and set as properties on the controller:

public function __construct()
{
    $this->middleware(function ($request, $next) {
        $this->user = $request->user();

        return $next($request);
    });
}

Notes:

1. To allow middleware closures, I had to rework the router's sortMiddleware method to not use collections, since contains and search do something else (invoke it) when passed a closure. That method looks a little nasty now 😕
2. There's a small change which I'm not sure would be considered breaking: the middleware property on the controller is now stored in a different format. I don't think this is meant to be tinkered with directly, but who knows?

[malhal]

Hi @JosephSilber just a quick question, is it reasonable to make use of a middleware class in this new way:

public function __construct()
{
    $this->middleware(function ($request, $next) {
         return (new MyMiddleware())->handle($request, $next);
    });
}

[JosephSilber]

That function has always accepted a string of a middleware class, which still works: $this->middleware(MyMiddleware::class);

[malhal]

Ha thanks @JosephSilber I did not know that! I've just done a PR to add to the Controller page examples of both of these.