[5.3] expectsEvents fired from ModelEvents

[SeoFood]

If we Mock the ModelEvents you cant Test anymore when ModelEvents fires an event, because withoutEvents mocks als the ModelEvents.

TestFile:

/**
 * @test
 */
public function it_fires_an_created_event()
{
    $this->expectsEvents(ModelCreated::class);

    factory(Model::class)->create();
}

Model:

/**
 * Register events
 *
 * @return void
 */
protected static function boot()
{
    parent::boot();

    static::created(function ($model) {
        event(new ModelCreated($model));
    });
}

This was ofc. working in Laravel 5.2. Added a Unit Test for better understanding.

[GrahamCampbell]

What happens if you put that code here before you register that created callback?

[SeoFood]

Makes no difference because the event will be mocked before the creation and override the ModelEvents.

[thecrypticace]

Oh, good catch @SeoFood.

cc @taylorotwell

You made this change after my PR but it definitely causes unexpected behavior. I get why you did it but it can definitely cause issues like the above.

And it's not just observers that break like I originally thought — firing events from a model event listener breaks too.

(related #14374 (comment))