Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Ensure encrypter exists #14038

Merged
merged 5 commits into from
Jun 18, 2016
Merged

[5.2] Ensure encrypter exists #14038

merged 5 commits into from
Jun 18, 2016

Conversation

greydnls
Copy link
Contributor

This PR:

  • declares encrypter as a proper property on the Queue class
  • ensures that encrypter exists, or throws an exception if it doesn't.

Without that guard in place there's the possibility of getting "function encrypt called on null" error.

@GrahamCampbell
Copy link
Member

Thanks, but this is actually a missuse of the encrypt exception.

@greydnls
Copy link
Contributor Author

@GrahamCampbell I figured that might be the case. What would be a better Exception to use?

@GrahamCampbell
Copy link
Member

I'd say just let it fatal error like it is now.

@taylorotwell taylorotwell merged commit 5c4595a into laravel:5.2 Jun 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants