[5.2] Remove need to release jobs that have been reserved too long #13833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
|
One thing that is confusing me is in the old method the attempts were being incremented when the jobs that were reserved too long were released. How is that being done now? |
|
Ah, i missed that. From a quick look, i think this should be able to be moved to when the job is initially reserved? I will take a look at it properly this evening and push any changes with tests for the attempts attribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making the getNextAvailableJob method pick up jobs that have been reserved too long, you can remove the need to periodically release jobs.
This is quite beneficial as it removes the need for an extra transaction (which sometimes cause locks) and eliminates two extra queries.
This is related to #7046. I also have a couple of other pull requests in mind that are related; these are in separate branches.
@taylorotwell